Обсуждение: Explicit NULL dereference (src/backend/commands/tablecmds.c)

Поиск
Список
Период
Сортировка

Explicit NULL dereference (src/backend/commands/tablecmds.c)

От
Ranier Vilela
Дата:
Hi,

Per Coverity.
CID 1453114 (#1 of 1): Explicit null dereferenced (FORWARD_NULL)
53. var_deref_model: Passing null pointer child_expr to strcmp, which dereferences it.

It is agreed that asserts should be used for error conditions that can never occur in the release.
But with errors that can occur, using assert does not make sense.

Better to make sure that strcmp can be called without risk.
Meanwhile, fix the strcmp call signature (const char).

#include <stdio.h>
#include <string.h>

int main()
{
    const char * s1="";
    const char * s2="0";
   
    if (strstr(s1, s2) != 0) {
        printf("found");
    } else {
        printf("not found");
    }
}
not found!

regards,
Ranier Vilela
Вложения

Re: Explicit NULL dereference (src/backend/commands/tablecmds.c)

От
Tom Lane
Дата:
Ranier Vilela <ranier.vf@gmail.com> writes:
> It is agreed that asserts should be used for error conditions that can
> never occur in the release.
> But with errors that can occur, using assert does not make sense.

On what grounds do you claim that those asserts are wrong?

Coverity's opinion counts for just about nothing these days.
A test case causing a crash would count, of course.

            regards, tom lane