Обсуждение: pg_receivewal: remove extra conn = NULL; in StreamLog

Hi,

It seems there's a redundant assignment statement conn = NULL in
pg_receivewal's StreamLog function. Attaching a tiny patch herewith.
Thoughts?

Regards,
Bharath Rupireddy.

> On 28 Aug 2021, at 14:10, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:

> It seems there's a redundant assignment statement conn = NULL in
> pg_receivewal's StreamLog function. Attaching a tiny patch herewith.
> Thoughts?

Agreed, while harmless this is superfluous since conn is already set to NULL
after the PQfinish call a few lines up (which was added in a4205fa00d526c3).
Unless there are objections I’ll apply this tomorrow or Monday.

--
Daniel Gustafsson        https://vmware.com/

On Sun, Aug 29, 2021 at 1:27 AM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 28 Aug 2021, at 14:10, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:
>
> > It seems there's a redundant assignment statement conn = NULL in
> > pg_receivewal's StreamLog function. Attaching a tiny patch herewith.
> > Thoughts?
>
> Agreed, while harmless this is superfluous since conn is already set to NULL
> after the PQfinish call a few lines up (which was added in a4205fa00d526c3).
> Unless there are objections I’ll apply this tomorrow or Monday.

Thanks for picking this up. I added this to CF to not lose it in the
wild - https://commitfest.postgresql.org/34/3317/

Regards,
Bharath Rupireddy.

> On 1 Sep 2021, at 10:58, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:
>
> On Sun, Aug 29, 2021 at 1:27 AM Daniel Gustafsson <daniel@yesql.se> wrote:
>>
>>> On 28 Aug 2021, at 14:10, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:
>>
>>> It seems there's a redundant assignment statement conn = NULL in
>>> pg_receivewal's StreamLog function. Attaching a tiny patch herewith.
>>> Thoughts?
>>
>> Agreed, while harmless this is superfluous since conn is already set to NULL
>> after the PQfinish call a few lines up (which was added in a4205fa00d526c3).
>> Unless there are objections I’ll apply this tomorrow or Monday.
>
> Thanks for picking this up. I added this to CF to not lose it in the
> wild - https://commitfest.postgresql.org/34/3317/

Pushed to master, and entry closed. Thanks.

--
Daniel Gustafsson        https://vmware.com/