Обсуждение: Fix typo in comments

Поиск
Список
Период
Сортировка

Fix typo in comments

От
"houzj.fnst@fujitsu.com"
Дата:
Hi,

When reviewing other patches, I noticed two typos:

1.
src/backend/parser/gram.y
ALTER TABLE <name> ALTER [COLUMN] <colname> RESET ( column_parameter = value [, ... ] )

RESET cannot specify value.

2.
src/backend/utils/adt/xid8funcs.c
* Same as pg_current_xact_if_assigned() but doesn't assign a new xid if there

pg_current_xact_if_assigned() should be pg_current_xact_id()

Best regards,
Hou zhijie


Вложения

Re: Fix typo in comments

От
Fujii Masao
Дата:

On 2021/09/02 20:54, houzj.fnst@fujitsu.com wrote:
> Hi,
> 
> When reviewing other patches, I noticed two typos:

Thanks! Both fixes look good to me.
Barring any objection, I will commit the patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



Re: Fix typo in comments

От
Fujii Masao
Дата:

On 2021/09/02 21:47, Fujii Masao wrote:
> 
> 
> On 2021/09/02 20:54, houzj.fnst@fujitsu.com wrote:
>> Hi,
>>
>> When reviewing other patches, I noticed two typos:
> 
> Thanks! Both fixes look good to me.
> Barring any objection, I will commit the patch.

Pushed. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION