Обсуждение: pgsql: Remove overzealous index deletion assertion.

Поиск
Список
Период
Сортировка

pgsql: Remove overzealous index deletion assertion.

От
Peter Geoghegan
Дата:
Remove overzealous index deletion assertion.

A broken HOT chain is not an unexpected condition, even when the offset
number points past the end of the page's line pointer array.
heap_prune_chain() does not (and never has) treated this condition as
unexpected, so derivative code in heap_index_delete_tuples() shouldn't
do so either.

Oversight in commit 4228817449.

The assertion can probably only fail on Postgres 14 and master.  Earlier
releases don't have commit 3c3b8a4b, which taught VACUUM to truncate the
line pointer array of heap pages.  Backpatch all the same, just to be
consistent.

Author: Peter Geoghegan <pg@bowt.ie>
Reported-By: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/17197-9438f31f46705182@postgresql.org
Backpatch: 12-, just like commit 4228817449.

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/955a6a893498a5d3af544d9c0b1c292b19ec1690

Modified Files
--------------
src/backend/access/heap/heapam.c | 3 ---
1 file changed, 3 deletions(-)