Обсуждение: Unnecessary call to resetPQExpBuffer in getIndexes

Поиск
Список
Период
Сортировка

Unnecessary call to resetPQExpBuffer in getIndexes

От
Julien Rouhaud
Дата:
Hi,

I just noticed that e2c52beecd (adding PeterE in Cc) added a resetPQExpBuffer()
which seems unnecessary since the variable is untouched since the initial
createPQExpBuffer().

Simple patch attached.

Вложения

Re: Unnecessary call to resetPQExpBuffer in getIndexes

От
Nathan Bossart
Дата:
On Wed, Feb 09, 2022 at 10:50:07AM +0800, Julien Rouhaud wrote:
> I just noticed that e2c52beecd (adding PeterE in Cc) added a resetPQExpBuffer()
> which seems unnecessary since the variable is untouched since the initial
> createPQExpBuffer().
> 
> Simple patch attached.

LGTM

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



Re: Unnecessary call to resetPQExpBuffer in getIndexes

От
Peter Eisentraut
Дата:
On 09.02.22 19:21, Nathan Bossart wrote:
> On Wed, Feb 09, 2022 at 10:50:07AM +0800, Julien Rouhaud wrote:
>> I just noticed that e2c52beecd (adding PeterE in Cc) added a resetPQExpBuffer()
>> which seems unnecessary since the variable is untouched since the initial
>> createPQExpBuffer().
>>
>> Simple patch attached.
> 
> LGTM

committed