Обсуждение: [pgAdmin][RM7187] ERD Image png 0 bytes
Hi Hackers,
Due to the limitations of HTML Canvas, if the image exceeds max width/height of 32767 then the image becomes empty.
To fix this, I have set the max limit of width and height to 32767. The ERD diagram will be cut if it exceeds the limit. The ERD tool will also throw an alert to inform the user in that case.
Please review.
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Вложения
Hi
On Wed, 6 Apr 2022 at 13:32, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,Due to the limitations of HTML Canvas, if the image exceeds max width/height of 32767 then the image becomes empty.To fix this, I have set the max limit of width and height to 32767. The ERD diagram will be cut if it exceeds the limit. The ERD tool will also throw an alert to inform the user in that case.Please review.
"The downloaded image has exceeded the maximum size of 32767 x 32767 pixels, and has been cropped to that size."
Can we similarly limit the size of the design canvas? 32767 x 32767 is huge.
Вложения
Hi Dave/Hackers,
Attached is the updated patch to change the message.
On Wed, Apr 6, 2022 at 6:07 PM Dave Page <dpage@pgadmin.org> wrote:
HiOn Wed, 6 Apr 2022 at 13:32, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Due to the limitations of HTML Canvas, if the image exceeds max width/height of 32767 then the image becomes empty.To fix this, I have set the max limit of width and height to 32767. The ERD diagram will be cut if it exceeds the limit. The ERD tool will also throw an alert to inform the user in that case.Please review."The downloaded image has exceeded the maximum size of 32767 x 32767 pixels, and has been cropped to that size."Can we similarly limit the size of the design canvas? 32767 x 32767 is huge.
There are just too many tables to fit in. I tried to create an SVG image instead of PNG and it went 200MB.
I will see if we can limit the size of canvas as well.
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Вложения
Thanks, the patch applied.
On Wed, Apr 6, 2022 at 6:02 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,Due to the limitations of HTML Canvas, if the image exceeds max width/height of 32767 then the image becomes empty.To fix this, I have set the max limit of width and height to 32767. The ERD diagram will be cut if it exceeds the limit. The ERD tool will also throw an alert to inform the user in that case.Please review.--Thanks,Aditya ToshniwalpgAdmin Hacker | Software Architect | edbpostgres.com"Don't Complain about Heat, Plant a TREE"
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB PostgresMobile: +91 976-788-8246