Обсуждение: Commitfest Closed
It has reached 2022-03-08 Anywhere on Earth[*] so I believe that means Postgres 15 Feature Freeze is in effect (modulo a couple patches that were held until the end of the commitfest to make merging easier). I've marked the commitfest closed and will be moving any patches that didn't receive feedback over to the next commitfest. I think this is most of the remaining patches though there may be a few Waiting for Author patches that can be Returned with Feedback or even Rejected. I'll do the Ready for Committer patches last to allow for the stragglers held back. It's always frustrating seeing patches get ignored but on the plus side nearly 100 patches are marked Committed and a lot of patches did get feedback. Thanks to all the reviewers and committers who put a lot of work in, especially in the last two weeks. I especially want to thank Andres who showed me how to use the cfbot to check on patch statuses and did a lot of work doing that until I was up to speed. [*] https://www.timeanddate.com/time/zones/aoe -- greg
On 2022-Apr-08, Greg Stark wrote: > Thanks to all the reviewers and committers who put a lot of work in, > especially in the last two weeks. I especially want to thank Andres > who showed me how to use the cfbot to check on patch statuses and did > a lot of work doing that until I was up to speed. Thanks for herding through the CF! -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
On Fri, Apr 8, 2022 at 5:58 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > Thanks for herding through the CF! +1 -- Peter Geoghegan
On Fri, Apr 08, 2022 at 08:09:16AM -0700, Peter Geoghegan wrote: > On Fri, Apr 8, 2022 at 5:58 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > > Thanks for herding through the CF! > > +1 +1!
I moved to next CF almost all the Needs Review and Waiting on Author patches. The remaining ones are either: 1) Bug fixes, Documentation, or testing patches that we may want to make Open Issues 2) Patches that look like we may want to mark Rejected or Returned with Feedback and start a new discussion 3) Patches whose email history confused me, such as where multiple patches are under discussion I also haven't gone through the Ready for Committer patches yet. I'll do that at the end of the day. Incidentally I marked a lot of the Waiting on Author patches as Needs Review before moving to the next CF because generally I think they were only Waiting on Author because of the cfbot failures and they were waiting on design feedback. Also, as another aside, I find a lot of the patches that haven't been reviewed were patches that were posted without any specific concerns or questions. That tends to imply the author thinks the patch is ready and just waiting on a comprehensive review which is a daunting task. I would suggest if you're an author posting a WIP and there's some specific uncertainties that you have about the patch that asking about them would encourage reviewers to dive in and help you make progress.
On Fri, Apr 08, 2022 at 08:48:57AM -0400, Greg Stark wrote: > Thanks to all the reviewers and committers who put a lot of work in, > especially in the last two weeks. I especially want to thank Andres > who showed me how to use the cfbot to check on patch statuses and did > a lot of work doing that until I was up to speed. Thanks for going through the CF, Greg! -- Michael