Обсуждение: Header checker scripts should fail on failure

Hi,

I thought commit 81b9f23c9c8 had my back, but nope, we still need to
make CI turn red if "headerscheck" and "cpluspluscheck" don't like our
patches (crake in the build farm should be a secondary defence...).
See attached.

On 2022-08-15 Mo 01:38, Thomas Munro wrote:
> Hi,
>
> I thought commit 81b9f23c9c8 had my back, but nope, we still need to
> make CI turn red if "headerscheck" and "cpluspluscheck" don't like our
> patches (crake in the build farm should be a secondary defence...).
> See attached.


Yeah, the buildfarm module works around that by looking for non-empty
output, but this is better,


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Hi,

On 2022-08-15 17:38:21 +1200, Thomas Munro wrote:
> I thought commit 81b9f23c9c8 had my back, but nope, we still need to
> make CI turn red if "headerscheck" and "cpluspluscheck" don't like our
> patches (crake in the build farm should be a secondary defence...).
> See attached.

+1

Greetings,

Andres Freund