Обсуждение: (non) translatable string splicing

I was surprised to see that this has been here for a few years (since
77517ba59) without complaints or inquiries from translators.

src/bin/pg_upgrade/option.c:    check_required_directory(&old_cluster.bindir, "PGBINOLD", false,
src/bin/pg_upgrade/option.c-                                                     "-b", _("old cluster binaries
reside"),false);
 
src/bin/pg_upgrade/option.c:    check_required_directory(&new_cluster.bindir, "PGBINNEW", false,
src/bin/pg_upgrade/option.c-                                                     "-B", _("new cluster binaries
reside"),true);
 
src/bin/pg_upgrade/option.c:    check_required_directory(&old_cluster.pgdata, "PGDATAOLD", false,
src/bin/pg_upgrade/option.c-                                                     "-d", _("old cluster data resides"),
false);
src/bin/pg_upgrade/option.c:    check_required_directory(&new_cluster.pgdata, "PGDATANEW", false,
src/bin/pg_upgrade/option.c-                                                     "-D", _("new cluster data resides"),
false);
src/bin/pg_upgrade/option.c:    check_required_directory(&user_opts.socketdir, "PGSOCKETDIR", true,
src/bin/pg_upgrade/option.c-                                                     "-s", _("sockets will be created"),
false);

src/bin/pg_upgrade/option.c:                    pg_fatal("You must identify the directory where the %s.\n"
src/bin/pg_upgrade/option.c-                                     "Please use the %s command-line option or the %s
environmentvariable.",
 
src/bin/pg_upgrade/option.c-                                     description, cmdLineOption, envVarName);

Due to incomplete translation, that allows some pretty fancy output,
like:
| You must identify the directory where the residen los binarios del clúster antiguo.

That commit also does this a couple times:

+                        _(" which is an index on \"%s.%s\""),

-- 
Justin

On Fri, Dec 16, 2022 at 07:24:52AM -0600, Justin Pryzby wrote:
> Due to incomplete translation, that allows some pretty fancy output,
> like:
> | You must identify the directory where the residen los binarios del clúster antiguo.
>
> That commit also does this a couple times:
>
> +                        _(" which is an index on \"%s.%s\""),

Ugh.  Perhaps we could just simplify the wordings as of "index on
blah", "index on OID %u", "TOAST table for blah" and "TOAST table for
OID %u" with newlines after each item?
--
Michael

On 2022-Dec-16, Justin Pryzby wrote:

> I was surprised to see that this has been here for a few years (since
> 77517ba59) without complaints or inquiries from translators.

See https://postgr.es/m/13948.1501733752@sss.pgh.pa.us

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"It takes less than 2 seconds to get to 78% complete; that's a good sign.
A few seconds later it's at 90%, but it seems to have stuck there.  Did
somebody make percentages logarithmic while I wasn't looking?"
                http://smylers.hates-software.com/2005/09/08/1995c749.html

On Fri, Dec 16, 2022 at 8:25 AM Justin Pryzby <pryzby@telsasoft.com> wrote:
> Due to incomplete translation, that allows some pretty fancy output,
> like:
> | You must identify the directory where the residen los binarios del clúster antiguo.

I can't see how that could be mejor. :-)

--
Robert Haas
EDB: http://www.enterprisedb.com

At Mon, 19 Dec 2022 13:20:55 +0900, Michael Paquier <michael@paquier.xyz> wrote in
> On Fri, Dec 16, 2022 at 07:24:52AM -0600, Justin Pryzby wrote:
> > Due to incomplete translation, that allows some pretty fancy output,
> > like:
> > | You must identify the directory where the residen los binarios del clúster antiguo.
> >
> > That commit also does this a couple times:
> >
> > +                        _(" which is an index on \"%s.%s\""),

For this specific case I didn't feel a difficulty since it is
compatible with "This is blah" in that context.

> Ugh.  Perhaps we could just simplify the wordings as of "index on
> blah", "index on OID %u", "TOAST table for blah" and "TOAST table for
> OID %u" with newlines after each item?

I'm fine with just removing " which ". but I don't understand about
the extra newlines.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

At Mon, 19 Dec 2022 16:14:04 -0500, Robert Haas <robertmhaas@gmail.com> wrote in
> On Fri, Dec 16, 2022 at 8:25 AM Justin Pryzby <pryzby@telsasoft.com> wrote:
> > Due to incomplete translation, that allows some pretty fancy output,
> > like:
> > | You must identify the directory where the residen los binarios del clúster antiguo.
>
> I can't see how that could be mejor. :-)

It was quite annoying but not untranslatable. But the "the" before
"residen" looks like badly misplaced:p It should be a part of the
inner text ("residen los..").

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center