Обсуждение: No buildfarm animals are running both typedefs and --with-llvm
I did a preliminary test run of pgindent today, and was dismayed to see a bunch of misformatting in backend/jit/llvm/, which evidently is because the typedefs list available from the buildfarm no longer includes any LLVM typedefs. We apparently used to have at least one buildfarm animal that was configured --with-llvm and ran the "typedefs" task, but there aren't any today. I can manually prevent those typedefs from getting deleted from typedefs.list, but it'd be better if the normal process was taking care of this -- the more so because we're hoping to automate that process some more. regards, tom lane
On 2023-05-17 We 18:14, Tom Lane wrote:
I did a preliminary test run of pgindent today, and was dismayed to see a bunch of misformatting in backend/jit/llvm/, which evidently is because the typedefs list available from the buildfarm no longer includes any LLVM typedefs. We apparently used to have at least one buildfarm animal that was configured --with-llvm and ran the "typedefs" task, but there aren't any today. I can manually prevent those typedefs from getting deleted from typedefs.list, but it'd be better if the normal process was taking care of this -- the more so because we're hoping to automate that process some more.
Do you remember which animals that used to be? A lot of animals are not building with LLVM. Maybe we should encourage it more, e.g. by adding --with-llvm to the default config set in the sample file.
cheers
andrew
-- Andrew Dunstan EDB: https://www.enterprisedb.com
Andrew Dunstan <andrew@dunslane.net> writes: > On 2023-05-17 We 18:14, Tom Lane wrote: >> I did a preliminary test run of pgindent today, and was dismayed >> to see a bunch of misformatting in backend/jit/llvm/, which >> evidently is because the typedefs list available from the >> buildfarm no longer includes any LLVM typedefs. We apparently >> used to have at least one buildfarm animal that was configured >> --with-llvm and ran the "typedefs" task, but there aren't any >> today. > Do you remember which animals that used to be? Nope, but last night I configured indri to do it, so we have some typedefs coverage now. It'd be good to have more than one animal doing it though. regards, tom lane