Обсуждение: Re: pgsql: Ignore BRIN indexes when checking for HOT udpates

Поиск
Список
Период
Сортировка

Re: pgsql: Ignore BRIN indexes when checking for HOT udpates

От
Alvaro Herrera
Дата:
On 2021-Nov-30, Tomas Vondra wrote:

> Ignore BRIN indexes when checking for HOT udpates

I was trying to use RelationGetIndexAttrBitmap for something and
realized that its header comment does not really explain things very
well.  That was already the case before this commit, but it (this
commit) did add new possible values without mentioning them.  I propose
the attached comment-only patch.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
Al principio era UNIX, y UNIX habló y dijo: "Hello world\n".
No dijo "Hello New Jersey\n", ni "Hello USA\n".

Вложения

Re: pgsql: Ignore BRIN indexes when checking for HOT udpates

От
Tomas Vondra
Дата:
On 8/9/23 11:11, Alvaro Herrera wrote:
> On 2021-Nov-30, Tomas Vondra wrote:
> 
>> Ignore BRIN indexes when checking for HOT udpates
> 
> I was trying to use RelationGetIndexAttrBitmap for something and
> realized that its header comment does not really explain things very
> well.  That was already the case before this commit, but it (this
> commit) did add new possible values without mentioning them.  I propose
> the attached comment-only patch.
> 

+1

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



Re: pgsql: Ignore BRIN indexes when checking for HOT udpates

От
Alvaro Herrera
Дата:
On 2023-Aug-09, Tomas Vondra wrote:

> On 8/9/23 11:11, Alvaro Herrera wrote:
> > I was trying to use RelationGetIndexAttrBitmap for something and
> > realized that its header comment does not really explain things very
> > well.  That was already the case before this commit, but it (this
> > commit) did add new possible values without mentioning them.  I propose
> > the attached comment-only patch.
> 
> +1

Thanks for looking!  Pushed now.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/