Обсуждение: [MASSMAIL]call ATPostAlterTypeParse inconsistency

Поиск
Список
Период
Сортировка

[MASSMAIL]call ATPostAlterTypeParse inconsistency

От
jian he
Дата:
hi.
one minor issue.

within ATPostAlterTypeCleanup, we call ATPostAlterTypeParse:
ATPostAlterTypeParse(oldId, relid, InvalidOid,
(char *) lfirst(def_item),
wqueue, lockmode, tab->rewrite);


function ATPostAlterTypeParse is:
static void
ATPostAlterTypeParse(Oid oldId, Oid oldRelId, Oid refRelId, char *cmd,
List **wqueue, LOCKMODE lockmode, bool rewrite)

but tab->rewrite is an int.
so within ATPostAlterTypeCleanup we should call it like:

ATPostAlterTypeParse(oldId, relid, InvalidOid,
(char *) lfirst(def_item),
wqueue, lockmode, tab->rewrite != 0);

or

ATPostAlterTypeParse(oldId, relid, InvalidOid,
(char *) lfirst(def_item),
wqueue, lockmode, tab->rewrite > 0);