Обсуждение: add tab-complete for memory, serialize option and other minor issues.

Поиск
Список
Период
Сортировка

add tab-complete for memory, serialize option and other minor issues.

От
jian he
Дата:
hi.

I found some minor issues related to the EXPLAIN command.

cannot auto-complete with a white space.
src8=# explain (analyze,b

can auto-complete:
src8=# explain (analyze, b

to make tab-complete work, comma, must be followed with a white space,
not sure why.
--------------
explain (serialize binary) select 1;
ERROR:  EXPLAIN option SERIALIZE requires ANALYZE

do you think it's better to rephrase it as:
ERROR:  EXPLAIN option SERIALIZE requires ANALYZE option

since we have separate ANALYZE SQL commands.
--------------

     <para>
      Specify the output format, which can be TEXT, XML, JSON, or YAML.
      Non-text output contains the same information as the text output
      format, but is easier for programs to parse.  This parameter defaults to
      <literal>TEXT</literal>.
     </para>

should we add <literal> attribute for {TEXT, XML, JSON, YAML} in the
above paragraph?

--------------
i created a patch for tab-complete for memory, SERIALIZE option.

Вложения

Re: add tab-complete for memory, serialize option and other minor issues.

От
Tom Lane
Дата:
jian he <jian.universality@gmail.com> writes:
> to make tab-complete work, comma, must be followed with a white space,
> not sure why.

https://www.postgresql.org/message-id/3870833.1712696581%40sss.pgh.pa.us

Post-feature-freeze is no time to be messing with behavior as basic
as WORD_BREAKS, though.

            regards, tom lane



Re: add tab-complete for memory, serialize option and other minor issues.

От
Michael Paquier
Дата:
On Sat, Apr 27, 2024 at 11:15:47AM -0400, Tom Lane wrote:
> https://www.postgresql.org/message-id/3870833.1712696581%40sss.pgh.pa.us
>
> Post-feature-freeze is no time to be messing with behavior as basic
> as WORD_BREAKS, though.

Indeed.

By the way, that psql completion patch has fallen through the cracks
and I don't see a point in waiting for that, so I have applied it.
Note that the patch did not order the options according to the docs,
which was consistent on HEAD but not anymore with the patch.
--
Michael

Вложения