Re: [pgadmin-hackers] [pgAdmin4][runtime][patch]: Fix compilationerror for QtWebEngine

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: [pgadmin-hackers] [pgAdmin4][runtime][patch]: Fix compilationerror for QtWebEngine
Дата
Msg-id CA+OCxoy19b0-m3N1huQrOL59a+SqzrUoNjBWUWr0J6L_tk0aHQ@mail.gmail.com
обсуждение исходный текст
Ответ на [pgadmin-hackers] [pgAdmin4][runtime][patch]: Fix compilation error for QtWebEngine  (Neel Patel <neel.patel@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Thanks, applied.

On Mon, May 15, 2017 at 10:48 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

While building runtime with QtWebEngine, we found 2 compilation errors which was introduced due to previous commit in runtime.
  • We set "setNetworkAccessManager" in WebEnginePage which was only required for Webkit so removed that statement.
  • "triggerAction" on WebPage is only required for Qt > 5 with WebKit only. Not required for WebEngine so added that condition.
Please find attached fix for the same. Do review it and let me know for any queries.

Thanks,
Neel Patel


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: [pgadmin-hackers] pgAdmin 4 commit: While building runtime with QtWebEngine,we found 2 c
Следующее
От: Dave Page
Дата:
Сообщение: [pgadmin-hackers] pgAdmin 4 commit: Bump version in preparation for release.