Re: [pgAmin4][Patch] - Kerberos support for Windows Installer

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: [pgAmin4][Patch] - Kerberos support for Windows Installer
Дата
Msg-id CA+OCxozOnj+RFycxhmmni-mYXAn-Jw58bwWgXnFMqDkrXimSnQ@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAmin4][Patch] - Kerberos support for Windows Installer  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Ответы Re: [pgAmin4][Patch] - Kerberos support for Windows Installer  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi

On Thu, Jan 21, 2021 at 7:11 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to add the Kerberos support in the Windows installer script.

A couple of comments:

- The file names should be in lower case in the COPY lines. It will still work of course, but for consistency and style...
- There's no check that the environment variable is set to a valid value. For others, we have code block like:

IF NOT EXIST "%PGADMIN_QT_DIR%" (
    ECHO !PGADMIN_QT_DIR! does not exist.
    ECHO Please install Qt and set the PGADMIN_QT_DIR environment variable.
    EXIT /B 1
)
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.
Следующее
От: Akshay Joshi
Дата:
Сообщение: pgAdmin 4 commit: Revert "Fixed an issue where shared server entries no