Re: [pgAmin4][Patch] - Kerberos support for Windows Installer

Поиск
Список
Период
Сортировка
От Khushboo Vashi
Тема Re: [pgAmin4][Patch] - Kerberos support for Windows Installer
Дата
Msg-id CAFOhELfFzkwDBX22K3fsTg+6piPkimvXPw1JVejVauWTsCTt8Q@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAmin4][Patch] - Kerberos support for Windows Installer  (Dave Page <dpage@pgadmin.org>)
Ответы Re: [pgAmin4][Patch] - Kerberos support for Windows Installer  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi Dave,

Please find the attached updated patch.

Thanks,
Khushbo

On Thu, Jan 21, 2021 at 3:17 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Jan 21, 2021 at 7:11 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to add the Kerberos support in the Windows installer script.

A couple of comments:

- The file names should be in lower case in the COPY lines. It will still work of course, but for consistency and style...
Fixed. 
- There's no check that the environment variable is set to a valid value. For others, we have code block like:

Fixed. 
IF NOT EXIST "%PGADMIN_QT_DIR%" (
    ECHO !PGADMIN_QT_DIR! does not exist.
    ECHO Please install Qt and set the PGADMIN_QT_DIR environment variable.
    EXIT /B 1
)
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com

Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Akshay Joshi
Дата:
Сообщение: Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.
Следующее
От: Nikhil Mohite
Дата:
Сообщение: Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.