Re: [sqlsmith] Crash on GUC serialization

On Sat, Nov 19, 2016 at 9:51 AM, Andreas Seltenreich <seltenreich@gmx.de> wrote:
> Michael Paquier writes:
>
>> [2. text/plain; fix-guc-string-eval.patch]
>
> I'm afraid taking care of the length computation is not sufficient.
> ISTM like it'll still try to serialize the NULL pointer later on in
> serialize_variable:
>
> ,----[ guc.c:9108 ]
> | case PGC_STRING:
> |     {
> |       struct config_string *conf = (struct config_string *) gconf;
> |       do_serialize(destptr, maxbytes, "%s", *conf->variable);
> `----

Hm, yes. Using an empty string strikes as being the best match.
--
Michael