Hi.
Here is another review comment for the patch v43-0001.
======
src/bin/pg_dump/pg_dump.c
1. getSubscriptions
+ if (fout->remoteVersion >= 170000)
+ appendPQExpBufferStr(query,
+ " subfailoverstate\n");
+ else
+ appendPQExpBuffer(query,
+ " '%c' AS subfailoverstate\n",
+ LOGICALREP_FAILOVER_STATE_DISABLED);
+
That first appended string should include the table alias same as all
the nearby code does.
e.g. " subfailoverstate\n" should be " s.subfailoverstate\n"
======
Kind Regards,
Peter Smith.
Fujitsu Australia