Fix RLS policy usage in MERGE.
If MERGE executes an UPDATE action on a table with row-level security,
the code incorrectly applied the WITH CHECK clauses from the target
table's INSERT policies to new rows, instead of the clauses from the
table's UPDATE policies. In addition, it failed to check new rows
against the target table's SELECT policies, if SELECT permissions were
required (likely to always be the case).
In addition, if MERGE executes a DO NOTHING action for matched rows,
the code incorrectly applied the USING clauses from the target table's
DELETE policies to existing target tuples. These policies were applied
as checks that would throw an error, if they did not pass.
Fix this, so that a MERGE UPDATE action applies the same RLS policies
as a plain UPDATE query with a WHERE clause, and a DO NOTHING action
does not apply any RLS checks (other than adding clauses from SELECT
policies to the join).
Back-patch to v15, where MERGE was introduced.
Dean Rasheed, reviewed by Stephen Frost.
Security: CVE-2023-39418
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/cb2ae5741f2458a474ed3c31458d242e678ff229
Modified Files
--------------
src/backend/executor/nodeModifyTable.c | 7 +--
src/backend/rewrite/rowsecurity.c | 85 ++++++++++++++++++++++---------
src/test/regress/expected/rowsecurity.out | 58 ++++++++++++++++-----
src/test/regress/sql/rowsecurity.sql | 52 +++++++++++++++----
4 files changed, 152 insertions(+), 50 deletions(-)