RE: Remove "FROM" in "DELETE FROM" when using tab-completion

Поиск
Список
Период
Сортировка
От tanghy.fnst@fujitsu.com
Тема RE: Remove "FROM" in "DELETE FROM" when using tab-completion
Дата
Msg-id OS0PR01MB6113B2E34CD215404BC00E1DFB539@OS0PR01MB6113.jpnprd01.prod.outlook.com
обсуждение исходный текст
Ответ на Re: Remove "FROM" in "DELETE FROM" when using tab-completion  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: Remove "FROM" in "DELETE FROM" when using tab-completion  (Dilip Kumar <dilipbalaut@gmail.com>)
Список pgsql-hackers
On Tuesday, May 11, 2021 2:53 PM, Michael Paquier <michael@paquier.xyz> wrote
>    else if (TailMatches("DELETE", "FROM", MatchAny))
>            COMPLETE_WITH("USING", "WHERE");
>-   /* XXX: implement tab completion for DELETE ... USING */
>
>Why are you removing that?  This sentence is still true, no?

IIRC, XXX in comment is used to flag something that is bogus but works.
When the sentence introduced here in f5ab0a14, the fix for "DELETE ... USING" is not as good as it is now.(I guess
that'swhy the comment was added). And for now, IMHO, we can remove the comment directly.  

If my understanding here is wrong, please let me know and that would be great to learn more about PG.

Regards,
Tang



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Multiple hosts in connection string failed to failover in non-hot standby mode
Следующее
От: Julien Rouhaud
Дата:
Сообщение: Re: compute_query_id and pg_stat_statements