Обсуждение: pgsql: Add flag values in WAL description to all heap records
Add flag values in WAL description to all heap records Hexadecimal is consistently used as format to not bloat too much the output but keep it readable. This information is useful mainly for debugging purposes with for example pg_waldump. Author: Michael Paquier Reviewed-by: Nathan Bossart, Dmitry Dolgov, Andres Freund, Álvaro Herrera Discussion: https://postgr.es/m/20180413034734.GE1552@paquier.xyz Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/3be97b97ed37b966173f027091f21d8a7605e2a5 Modified Files -------------- src/backend/access/rmgrdesc/heapdesc.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-)
On 2018-Nov-14, Michael Paquier wrote: > Add flag values in WAL description to all heap records > > Hexadecimal is consistently used as format to not bloat too much the > output but keep it readable. This information is useful mainly for > debugging purposes with for example pg_waldump. Just noticed: ISTM we should also print the infobits_set flags in xl_heap_lock and xl_heap_lock_updated. I can add those. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Wed, Nov 14, 2018 at 11:02:46AM -0300, Alvaro Herrera wrote: > Just noticed: ISTM we should also print the infobits_set flags in > xl_heap_lock and xl_heap_lock_updated. I can add those. OK, feel free to do so if you have time, or I can add them myself if you would like me to do so. Another thing I was wondering is if we should show the information of individual tuples data for XLOG_HEAP2_FREEZE_PAGE records (under a different option?). -- Michael