Обсуждение: Wiki page background suddenly grey

Поиск
Список
Период
Сортировка

Wiki page background suddenly grey

От
Christoph Berg
Дата:
Hi,

wiki pages used to have a nice white background for good
black-on-white contrast, but now the background is grey and everything
looks dim.

It is perhaps not immediately visible, but the <pre> boxes on the Apt
page used to be really visible, now they are just some lightish grey
on some mediumish grey:

https://wiki.postgresql.org/wiki/Apt
https://www.df7cb.de/s/2023-06-12.143740.RVJvp4.png (bottom)

Please consider reverting to white.

Christoph



Re: Wiki page background suddenly grey

От
Dave Page
Дата:
Hi

On Mon, 12 Jun 2023 at 21:01, Christoph Berg <myon@debian.org> wrote:
Hi,

wiki pages used to have a nice white background for good
black-on-white contrast, but now the background is grey and everything
looks dim.

It is perhaps not immediately visible, but the <pre> boxes on the Apt
page used to be really visible, now they are just some lightish grey
on some mediumish grey:

https://wiki.postgresql.org/wiki/Apt
https://www.df7cb.de/s/2023-06-12.143740.RVJvp4.png (bottom)

Please consider reverting to white.

I hadn't really noticed that - it looks significantly more grey in your screenshot than it does on my screens.

So it would have happened (inadvertently) in the recent MediaWiki upgrade. From what I can see, it's being set on line 132 of load.php. That's easy enough to change of course, but I need to go figure out the best way to do it as we probably have our own package which will need to be updated and re-deployed, and like most of the sysadmin team, I'm somewhat wary of breaking MediaWiki in the process as it's finicky at the best of times :-)
 
--

Re: Wiki page background suddenly grey

От
Dave Page
Дата:


On Tue, 13 Jun 2023 at 09:27, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Mon, 12 Jun 2023 at 21:01, Christoph Berg <myon@debian.org> wrote:
Hi,

wiki pages used to have a nice white background for good
black-on-white contrast, but now the background is grey and everything
looks dim.

It is perhaps not immediately visible, but the <pre> boxes on the Apt
page used to be really visible, now they are just some lightish grey
on some mediumish grey:

https://wiki.postgresql.org/wiki/Apt
https://www.df7cb.de/s/2023-06-12.143740.RVJvp4.png (bottom)

Please consider reverting to white.

I hadn't really noticed that - it looks significantly more grey in your screenshot than it does on my screens.

So it would have happened (inadvertently) in the recent MediaWiki upgrade. From what I can see, it's being set on line 132 of load.php. That's easy enough to change of course, but I need to go figure out the best way to do it as we probably have our own package which will need to be updated and re-deployed, and like most of the sysadmin team, I'm somewhat wary of breaking MediaWiki in the process as it's finicky at the best of times :-)

OK, I think I got it, and nothing seems to have exploded. How does the contrast look to you now?

I've only tweaked the background for now - can see about the boxes if you think they still look dim.

--

Re: Wiki page background suddenly grey

От
Alvaro Herrera
Дата:
On 2023-Jun-13, Dave Page wrote:

> So it would have happened (inadvertently) in the recent MediaWiki upgrade.

Yeah, forward-porting the mediawiki skin changes was by far the
trickiest part of the mediawiki upgrade.

> From what I can see, it's being set on line 132 of load.php.

Hmm, where is that?

> That's easy
> enough to change of course, but I need to go figure out the best way to do
> it as we probably have our own package which will need to be updated and
> re-deployed, and like most of the sysadmin team, I'm somewhat wary of
> breaking MediaWiki in the process as it's finicky at the best of times :-)

Hmm, I wonder if it would be better to change it in the skin files
instead -- see var/lib/mediawiki/skins/PostgreSQL in the
pginfra-wrap-mediawiki package.

I see that skins/PostgreSQL/resources/variables.less has this line
@content-background: #ffffff;
(this value is referenced elsewhere in the skin files) but apparently
it's being ignored or something ...

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
 Are you not unsure you want to delete Firefox?
       [Not unsure]     [Not not unsure]    [Cancel]
                   http://smylers.hates-software.com/2008/01/03/566e45b2.html



Re: Wiki page background suddenly grey

От
Alvaro Herrera
Дата:
On 2023-Jun-13, Alvaro Herrera wrote:

> I see that skins/PostgreSQL/resources/variables.less has this line
> @content-background: #ffffff;
> (this value is referenced elsewhere in the skin files) but apparently
> it's being ignored or something ...

Oh, I see you had just modified it before I looked at it.  Nevermind ...
and thanks for taking care of it.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"¿Cómo puedes confiar en algo que pagas y que no ves,
y no confiar en algo que te dan y te lo muestran?" (Germán Poo)



Re: Wiki page background suddenly grey

От
Dave Page
Дата:


On Tue, 13 Jun 2023 at 10:04, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
On 2023-Jun-13, Alvaro Herrera wrote:

> I see that skins/PostgreSQL/resources/variables.less has this line
> @content-background: #ffffff;
> (this value is referenced elsewhere in the skin files) but apparently
> it's being ignored or something ...

Oh, I see you had just modified it before I looked at it.  Nevermind ...
and thanks for taking care of it

:-). Yeah, getting back to the source of where it's set is what I was alluding to when I said about "the best way to do it". The content in load.php is just what ends up in the browser.

--

Re: Wiki page background suddenly grey

От
Christoph Berg
Дата:
Re: Dave Page
> :-). Yeah, getting back to the source of where it's set is what I was
> alluding to when I said about "the best way to do it". The content in
> load.php is just what ends up in the browser.

Thanks, looks good again!

Christoph