RE: Is there a mistake in line 22 of Make.bat?

Поиск
Список
Период
Сортировка
От Huang, Jun
Тема RE: Is there a mistake in line 22 of Make.bat?
Дата
Msg-id 56f1a74304354a00bf36bd3cd0a4f75b@G08CNEXMBPEKD06.g08.fujitsu.local
обсуждение исходный текст
Ответ на Re: Is there a mistake in line 22 of Make.bat?  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Дерево обсуждения

Thanks for your answer.

 

--

Thanks & Regards

HuangJ

 

From: Dave Page <dpage@pgadmin.org>
Sent: Thursday, January 14, 2021 5:15 PM
To: Huang, Jun/黄 军 <huangj.fnst@cn.fujitsu.com>
Cc: pgadmin-hackers@postgresql.org
Subject: Re: Is there a mistake in line 22 of Make.bat?

 

Hi

 

On Thu, Jan 14, 2021 at 1:20 AM Huang, Jun <huangj.fnst@cn.fujitsu.com> wrote:

Hi,

The following code is line 22 of Make.bat:
        if "%Platform%" == "X86" (

I tried `echo %Platform%` in VS2017 x86 native Tools Command Prompt, the result is "x86"(not "X86").
If it's a mistake, the attached patch adds the changes.

 

Hmm, on the 32bit build VM I get this:

 

C:\Program Files (x86)\Microsoft Visual C++ Build Tools>echo %Platform%
X86

C:\Program Files (x86)\Microsoft Visual C++ Build Tools>

 

Which explains why everything works in the production builds. Note that that system is VS 2015 though, but the 64 bit builds are VS 2017 iirc.

 

Given that 32 bit Windows builds will be dropped soon, I'm inclined to leave this as-is for now.

 

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: Quick search for menu items & help articles
Следующее
От: Akshay Joshi
Дата:
Сообщение: pgAdmin 4 commit: Ensure that the user should be able to specify an old